lkml.org 
[lkml]   [2011]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 5/5] gpio/gpio-stmpe: ADD support for stmpe variant 801
On Mon, Nov 21, 2011 at 09:50:05AM +0530, Viresh Kumar wrote:
> On 11/18/2011 5:29 PM, Rabin Vincent wrote:

> > (1) for 801, when clearing one GPIO, sets all the others.

> I assumed stmpe_set_bits will only affect bits which are 1
> in mask and i was wrong. :(

That does look like a straight bug in stmpe_set_bits() which ought to be
fixed regardless of anything else.

> > (2) for other devices, adds an an unnecessary read (within stmpe_set_bits()),
> > which wasn't there before.

> Correct.

> > Please rework to something like:

Looking at the code in stmpe.c it might be as well to convert to regmap
which would if nothing else save a bunch of custom code in the driver
and let you use the cache code to eliminate the read. Probably that
will help eliminate reads in other places too.


\
 
 \ /
  Last update: 2011-11-21 15:53    [W:0.095 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site