lkml.org 
[lkml]   [2011]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subjectre: [SCSI] compat_ioct: fix bsg SG_IO
From
Date
On Wed, 2011-11-02 at 11:16 +0300, Dan Carpenter wrote:
> 84eb8fb42c120 "[SCSI] compat_ioct: fix bsg SG_IO" introduces an
> uninitialized variable use.
>
> 278 static int sg_ioctl_trans(unsigned int fd, unsigned int cmd,
> 279 sg_io_hdr32_t __user *sgio32)
> 280 {
> 281 sg_io_hdr_t __user *sgio;
> 282 u16 iovec_count;
> 283 u32 data;
> 284 void __user *dxferp;
> 285 int err;
> 286 int interface_id;
> 287
> 288 if (get_user(interface_id, &sgio32->interface_id))
> ^^^^^^
> sgio32 is unitialized here. Unfortunately Gcc doesn't warn about it.

I don't quite understand what makes you think that: it's passed in as an
argument to the function. It's a pointer to the userspace 32 bit
representation of the structure. The use logic is a slightly convoluted
way of saying we only understand the 'S' header but we're going to let
the real ioctl routine say what the error is if it's not type 'S'.

James




\
 
 \ /
  Last update: 2011-11-02 10:03    [W:0.056 / U:6.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site