Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [Kgdb-bugreport] [PATCH v2 3/3] param: make /sys/module/*/paramaters optional | Date | Thu, 03 Nov 2011 08:21:30 +1030 |
| |
On Wed, 2 Nov 2011 09:24:35 -0700, Tim Bird <tim.bird@am.sony.com> wrote: > On 11/2/2011 6:30 AM, Jason Wessel wrote: > > On 11/01/2011 06:50 PM, David Decotigny wrote: > I would also like to see the size numbers. However, to address > Jason's concern, I think it's safe to assume that when someone is > getting this aggressive with system size, they'll start leaving debug > features on the floor (printk, kdb, etc.). What would be appropriate, > IMHO, would be to add a config dependency for kgdb/kdb and > NOT resurrect /proc items. There's work in progress in linux-tiny > to tackle /proc configurability, and adding back /proc interfaces > is likely to just have the issue resurface there. > -- Tim
This is already CONFIG_EXPERT; I don't think anyone really wants to turn this off.
Yes, I think the patch comes from a false premise: that the reason that people don't expost module params in sysfs is due to memory usage, and that providing a way to turn that off will alleviate their fears.
So, my advice to David: just change the perms on any and all module parameters you want. *Then* if someone complains about bloat, you can re-submit these patches and cc: me.
(BTW, don't like the first patch: static is nice, but keeping related code together is nicer).
Cheers, Rusty.
| |