lkml.org 
[lkml]   [2011]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: Improve cmtime update on shared writable mmaps
    On Tue, Nov 01, 2011 at 04:02:24PM -0700, Andy Lutomirski wrote:
    > Hmm. Isn't it permitted to at least read from an fs while holding the
    > page lock? I thought that the page lock was held for the entire
    > duration of a read and at the beginning of writeback.
    >
    > I can push this down to the ->writepage implementations or to the
    > clear_page_dirty_for_io callers, but that will result in a bigger
    > patch.

    Besides the current way that seems to be the only reasonable place to
    do it. Pushing it into ->writepage also has the benefit that
    filesystems could piggy back the ctime update onto the transaction that
    updates the extent tree.



    \
     
     \ /
      Last update: 2011-11-02 08:41    [W:4.394 / U:0.276 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site