[lkml]   [2011]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gpio: fix build error in include/asm-generic/gpio.h
On Thu, Oct 20, 2011 at 21:38, Hamo wrote:
> Should call the platform-specific __gpio_{get,set}_value
> instead of generic gpio_{get,set}_value
> --- a/include/asm-generic/gpio.h
> +++ b/include/asm-generic/gpio.h
>  static inline int gpio_get_value_cansleep(unsigned gpio)
>  {
>        might_sleep();
> -       return gpio_get_value(gpio);
> +       return __gpio_get_value(gpio);
>  }
>  static inline void gpio_set_value_cansleep(unsigned gpio, int value)
>  {
>        might_sleep();
> -       gpio_set_value(gpio, value);
> +       __gpio_set_value(gpio, value);
>  }

your change log says very little, and this change looks incorrect to
me. __gpio_xxx type funcs exist in the GPIOLIB case, not in the
!GPIOLIB case. your patch is changing the !GPIOLIB case. so i don't
see how this could work: you're now calling funcs which are not
guaranteed to exist.

i notice this because i'm seeing build failures for somethings that
are using asm-generic/gpio.h, but not GPIOLIB.

so could you explain why exactly you need this and why you think this
is the right route to go ?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2011-11-02 21:19    [W:0.064 / U:15.332 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site