lkml.org 
[lkml]   [2011]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Stageing: bcm: fixed spacing coding style in led_control.c
On Wed, Nov 02, 2011 at 04:54:55AM +0200, Joe Perches wrote:
> On Tue, 2011-11-01 at 23:22 +0300, Dan Carpenter wrote:
> > You're right that this driver needs a lot of work.
> []
> > I'd prefer a series of patches:
>
> Thanks Dan, that's a good summary of useful changes
> and their best order. Couple of comments:
>
> > [patch 1/3] Staging: bcm: fix whitespace in led_control.c
> > This would address tabs vs spaces, extra prohibited spaces, and
> > spaces required around certain chars. Also it would add blank lines
> > between functions and between declarations and code.
>
> And verify with git diff -w and object diffs.
>

How are you doing the object diff? I've tried just using diff
against the object files but the line number changes mess everything
up.

regards,
dan carpenter
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-11-02 07:29    [W:0.046 / U:0.708 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site