lkml.org 
[lkml]   [2011]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[rfc 3/3] mm: vmscan: revert file list boost on lru addition
The idea in 9ff473b 'vmscan: evict streaming IO first' was to steer
reclaim focus onto file pages with every new file page that hits the
lru list, so that an influx of used-once file pages does not lead to
swapping of anonymous pages.

The problem is that nobody is fixing up the balance if the pages in
fact become part of the resident set.

Anonymous page creation is neutral to the inter-lru balance, so even a
comparably tiny number of heavily used file pages tip the balance in
favor of the file list.

In addition, there is no refault detection, and every refault will
bias the balance even more. A thrashing file working set will be
mistaken for a very lucrative source of reclaimable pages.

As anonymous pages are no longer swapped above a certain priority
level, this mechanism is no longer needed. Used-once file pages
should get reclaimed before the VM even considers swapping.

Signed-off-by: Johannes Weiner <jweiner@redhat.com>
---
mm/swap.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/swap.c b/mm/swap.c
index 3a442f1..33e5387 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -683,7 +683,6 @@ static void ____pagevec_lru_add_fn(struct page *page, void *arg)
SetPageLRU(page);
if (active)
SetPageActive(page);
- update_page_reclaim_stat(zone, page, file, active);
add_page_to_lru_list(zone, page, lru);
}

--
1.7.6.4


\
 
 \ /
  Last update: 2011-11-02 17:35    [W:0.099 / U:34.696 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site