lkml.org 
[lkml]   [2011]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Intel-gfx] [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control
    On Tue,  1 Nov 2011 23:20:24 -0700
    Keith Packard <keithp@keithp.com> wrote:

    > Every usage of PCH_PP_CONTROL sets the PANEL_UNLOCK_REGS value to
    > ensure that writes will be respected, move this to a common function
    > to make the driver cleaner.
    >
    > No functional changes.
    >
    > Signed-off-by: Keith Packard <keithp@keithp.com>
    > ---
    > drivers/gpu/drm/i915/intel_dp.c | 37 +++++++++++++++++++------------------
    > 1 files changed, 19 insertions(+), 18 deletions(-)

    Can't we just set UNLOCK_REGS at load time and have asserts sprinkled
    here and there?

    --
    Jesse Barnes, Intel Open Source Technology Center
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-11-02 17:05    [W:0.022 / U:0.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site