Messages in this thread Patch in this message | | | From | Edward Donovan <> | Subject | [PATCH] genirq: fix second 2.6.39 regression in irqfixup, irqpoll | Date | Sat, 19 Nov 2011 20:54:23 -0500 |
| |
commit fa2727("genirq: Fixup poll handling") introduced a regression that broke irqfixup/irqpoll for some hardware configurations. That patch removed a test that checked for 'action->handler' returning IRQ_HANDLED, before acting on the IRQ. Putting this test back restores the functionality lost since 2.6.39. In the current set of tests after 'action' is set, it must precede '!action->next' to take effect.
With this and the previous patch to spurious.c, c75d720fca8a, all IRQ regressions that I have encountered are fixed.
Signed-off-by: Edward Donovan <edward.donovan@numble.net> --- kernel/irq/spurious.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index b5f4742..dc813a9 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c @@ -84,7 +84,9 @@ static int try_one_irq(int irq, struct irq_desc *desc, bool force) */ action = desc->action; if (!action || !(action->flags & IRQF_SHARED) || - (action->flags & __IRQF_TIMER) || !action->next) + (action->flags & __IRQF_TIMER) || + (action->handler(irq, action->dev_id) == IRQ_HANDLED) || + !action->next) goto out; /* Already running on another processor */ -- 1.7.5.4
| |