Messages in this thread Patch in this message | | | Subject | [PATCH] x86, mrst: Use kmemdup rather than duplicating its implementation | From | Thomas Meyer <> | Date | Thu, 17 Nov 2011 23:43:40 +0100 |
| |
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100 +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 11:01:48.424910801 +0100 @@ -656,13 +656,12 @@ static void __init intel_scu_spi_device_ return; } - new_dev = kzalloc(sizeof(*sdev), GFP_KERNEL); + new_dev = kmemdup(sdev, sizeof(*sdev), GFP_KERNEL); if (!new_dev) { pr_err("failed to alloc mem for delayed spi dev %s\n", sdev->modalias); return; } - memcpy(new_dev, sdev, sizeof(*sdev)); spi_devs[spi_next_dev++] = new_dev; } @@ -677,13 +676,12 @@ static void __init intel_scu_i2c_device_ return; } - new_dev = kzalloc(sizeof(*idev), GFP_KERNEL); + new_dev = kmemdup(idev, sizeof(*idev), GFP_KERNEL); if (!new_dev) { pr_err("failed to alloc mem for delayed i2c dev %s\n", idev->type); return; } - memcpy(new_dev, idev, sizeof(*idev)); i2c_bus[i2c_next_dev] = bus; i2c_devs[i2c_next_dev++] = new_dev;
| |