lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 23/25] Staging: comedi: fix printk issue in pcl818.c
    Date
    This is a patch to the pcl818.c file that fixes up a printk
    warning found by the checkpatch.pl tool

    Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
    ---
    drivers/staging/comedi/drivers/pcl818.c | 13 +++++++------
    1 files changed, 7 insertions(+), 6 deletions(-)

    diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
    index 4e134e9..c207b25 100644
    --- a/drivers/staging/comedi/drivers/pcl818.c
    +++ b/drivers/staging/comedi/drivers/pcl818.c
    @@ -1745,22 +1745,23 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)

    /* claim our I/O space */
    iobase = it->options[0];
    - printk("comedi%d: pcl818: board=%s, ioport=0x%03lx",
    - dev->minor, this_board->name, iobase);
    + printk
    + ("comedi%d: pcl818: board=%s, ioport=0x%03lx",
    + dev->minor, this_board->name, iobase);
    devpriv->io_range = this_board->io_range;
    if ((this_board->fifo) && (it->options[2] == -1)) { /* we've board with FIFO and we want to use FIFO */
    devpriv->io_range = PCLx1xFIFO_RANGE;
    devpriv->usefifo = 1;
    }
    if (!request_region(iobase, devpriv->io_range, "pcl818")) {
    - printk("I/O port conflict\n");
    + comedi_error(dev, "I/O port conflict\n");
    return -EIO;
    }

    dev->iobase = iobase;

    if (pcl818_check(iobase)) {
    - printk(", I can't detect board. FAIL!\n");
    + comedi_error(dev, "I can't detect board. FAIL!\n");
    return -EIO;
    }

    @@ -1784,7 +1785,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    irq);
    irq = 0; /* Can't use IRQ */
    } else {
    - printk(", irq=%u", irq);
    + printk(KERN_DEBUG "irq=%u", irq);
    }
    }
    }
    @@ -1815,7 +1816,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    "pcl818 DMA (RTC)", dev)) {
    devpriv->dma_rtc = 1;
    devpriv->rtc_irq = RTC_IRQ;
    - printk(", dma_irq=%u", devpriv->rtc_irq);
    + printk(KERN_DEBUG "dma_irq=%u", devpriv->rtc_irq);
    } else {
    RTC_lock--;
    if (RTC_lock == 0) {
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-11-19 05:41    [W:0.022 / U:0.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site