lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/25] Staging: comedi: fix printk issue in cb_pcimdas.c
    Date
    This is a patch to the cb_pcimdas.c file that fixes up a printk
    warning found by the checkpatch.pl tool.

    converted printks to dev_version.
    Removed ifdef CBPCIMDAS_DEBUG and unecessary printk statements.

    Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
    ---
    drivers/staging/comedi/drivers/cb_pcimdas.c | 19 +++++++++++--------
    1 files changed, 11 insertions(+), 8 deletions(-)

    diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b/drivers/staging/comedi/drivers/cb_pcimdas.c
    index 5d25e78..8ba6942 100644
    --- a/drivers/staging/comedi/drivers/cb_pcimdas.c
    +++ b/drivers/staging/comedi/drivers/cb_pcimdas.c
    @@ -341,16 +341,19 @@ found:
    */
    static int cb_pcimdas_detach(struct comedi_device *dev)
    {
    -#ifdef CBPCIMDAS_DEBUG
    if (devpriv) {
    - printk("devpriv->BADR0 = 0x%lx\n", devpriv->BADR0);
    - printk("devpriv->BADR1 = 0x%lx\n", devpriv->BADR1);
    - printk("devpriv->BADR2 = 0x%lx\n", devpriv->BADR2);
    - printk("devpriv->BADR3 = 0x%lx\n", devpriv->BADR3);
    - printk("devpriv->BADR4 = 0x%lx\n", devpriv->BADR4);
    + dev_dbg(dev->hw_dev, "devpriv->BADR0 = 0x%lx\n",
    + devpriv->BADR0);
    + dev_dbg(dev->hw_dev, "devpriv->BADR1 = 0x%lx\n",
    + devpriv->BADR1);
    + dev_dbg(dev->hw_dev, "devpriv->BADR2 = 0x%lx\n",
    + devpriv->BADR2);
    + dev_dbg(dev->hw_dev, "devpriv->BADR3 = 0x%lx\n",
    + devpriv->BADR3);
    + dev_dbg(dev->hw_dev, "devpriv->BADR4 = 0x%lx\n",
    + devpriv->BADR4);
    }
    -#endif
    - printk("comedi%d: cb_pcimdas: remove\n", dev->minor);
    +
    if (dev->irq)
    free_irq(dev->irq, dev);
    if (devpriv) {
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-11-19 05:41    [W:0.021 / U:0.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site