lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/25] Staging: comedi: fix printk issue in cb_pcidas.c
    Date
    This is a patch to the cb_pcidas.c file that fixes up a printk
    warning found by the checkpatch.pl tool.

    converted printks to dev_printk and Removed unnecessary
    printk statements.

    Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
    ---
    drivers/staging/comedi/drivers/cb_pcidas.c | 17 +++++++----------
    1 files changed, 7 insertions(+), 10 deletions(-)

    diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c
    index 61968a5..7433646 100644
    --- a/drivers/staging/comedi/drivers/cb_pcidas.c
    +++ b/drivers/staging/comedi/drivers/cb_pcidas.c
    @@ -565,8 +565,6 @@ static int cb_pcidas_attach(struct comedi_device *dev,
    int index;
    int i;

    - printk("comedi%d: cb_pcidas: ", dev->minor);
    -
    /*
    * Allocate the private structure area.
    */
    @@ -576,7 +574,6 @@ static int cb_pcidas_attach(struct comedi_device *dev,
    /*
    * Probe the device to determine what device in the series it is.
    */
    - printk("\n");

    for_each_pci_dev(pcidev) {
    /* is it not a computer boards card? */
    @@ -600,20 +597,20 @@ static int cb_pcidas_attach(struct comedi_device *dev,
    }
    }

    - printk("No supported ComputerBoards/MeasurementComputing card found on "
    - "requested position\n");
    + dev_err(dev->hw_dev, "No supported ComputerBoards/MeasurementComputing card found on requested position\n");
    return -EIO;

    found:

    - printk("Found %s on bus %i, slot %i\n", cb_pcidas_boards[index].name,
    - pcidev->bus->number, PCI_SLOT(pcidev->devfn));
    + dev_dbg(dev->hw_dev, "Found %s on bus %i, slot %i\n",
    + cb_pcidas_boards[index].name, pcidev->bus->number,
    + PCI_SLOT(pcidev->devfn));

    /*
    * Enable PCI device and reserve I/O ports.
    */
    if (comedi_pci_enable(pcidev, "cb_pcidas")) {
    - printk(" Failed to enable PCI device and request regions\n");
    + dev_err(dev->hw_dev, "Failed to enable PCI device and request regions\n");
    return -EIO;
    }
    /*
    @@ -639,7 +636,8 @@ found:
    /* get irq */
    if (request_irq(devpriv->pci_dev->irq, cb_pcidas_interrupt,
    IRQF_SHARED, "cb_pcidas", dev)) {
    - printk(" unable to allocate irq %d\n", devpriv->pci_dev->irq);
    + dev_dbg(dev->hw_dev, "unable to allocate irq %d\n",
    + devpriv->pci_dev->irq);
    return -EINVAL;
    }
    dev->irq = devpriv->pci_dev->irq;
    @@ -768,7 +766,6 @@ found:
    */
    static int cb_pcidas_detach(struct comedi_device *dev)
    {
    - printk("comedi%d: cb_pcidas: remove\n", dev->minor);

    if (devpriv) {
    if (devpriv->s5933_config) {
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-11-19 05:41    [W:0.024 / U:119.752 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site