lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[22/26] xen-gntalloc: signedness bug in add_grefs()
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 99cb2ddcc617f43917e94a4147aa3ccdb2bcd77e upstream.

    gref->gref_id is unsigned so the error handling didn't work.
    gnttab_grant_foreign_access() returns an int type, so we can add a
    cast here, and it doesn't cause any problems.
    gnttab_grant_foreign_access() can return a variety of errors
    including -ENOSPC, -ENOSYS and -ENOMEM.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/xen/gntalloc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/xen/gntalloc.c
    +++ b/drivers/xen/gntalloc.c
    @@ -135,7 +135,7 @@ static int add_grefs(struct ioctl_gntall
    /* Grant foreign access to the page. */
    gref->gref_id = gnttab_grant_foreign_access(op->domid,
    pfn_to_mfn(page_to_pfn(gref->page)), readonly);
    - if (gref->gref_id < 0) {
    + if ((int)gref->gref_id < 0) {
    rc = gref->gref_id;
    goto undo;
    }



    \
     
     \ /
      Last update: 2011-11-19 01:11    [W:0.020 / U:59.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site