lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:sched/core] sched: Fix buglet in return_cfs_rq_runtime()
    Commit-ID:  fccfdc6f0d8c83c854eeb6d93aa158f0e551bd49
    Gitweb: http://git.kernel.org/tip/fccfdc6f0d8c83c854eeb6d93aa158f0e551bd49
    Author: Paul Turner <pjt@google.com>
    AuthorDate: Mon, 7 Nov 2011 20:26:34 -0800
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Wed, 16 Nov 2011 08:43:45 +0100

    sched: Fix buglet in return_cfs_rq_runtime()

    In return_cfs_rq_runtime() we want to return bandwidth when there are no
    remaining tasks, not "return" when this is the case.

    Signed-off-by: Paul Turner <pjt@google.com>
    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/20111108042736.623812423@google.com
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    kernel/sched_fair.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
    index ba0e1f4..a78ed27 100644
    --- a/kernel/sched_fair.c
    +++ b/kernel/sched_fair.c
    @@ -1756,7 +1756,7 @@ static void __return_cfs_rq_runtime(struct cfs_rq *cfs_rq)

    static __always_inline void return_cfs_rq_runtime(struct cfs_rq *cfs_rq)
    {
    - if (!cfs_rq->runtime_enabled || !cfs_rq->nr_running)
    + if (!cfs_rq->runtime_enabled || cfs_rq->nr_running)
    return;

    __return_cfs_rq_runtime(cfs_rq);

    \
     
     \ /
      Last update: 2011-11-19 00:43    [W:0.024 / U:1.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site