Messages in this thread Patch in this message | | | Date | Fri, 18 Nov 2011 18:27:09 +0100 | From | Andrea Arcangeli <> | Subject | Re: [PATCH 2/5] mm: compaction: Use synchronous compaction for /proc/sys/vm/compact_memory |
| |
On Fri, Nov 18, 2011 at 04:58:41PM +0000, Mel Gorman wrote: > When asynchronous compaction was introduced, the > /proc/sys/vm/compact_memory handler should have been updated to always > use synchronous compaction. This did not happen so this patch addresses > it. The assumption is if a user writes to /proc/sys/vm/compact_memory, > they are willing for that process to stall. > > Signed-off-by: Mel Gorman <mgorman@suse.de> > --- > mm/compaction.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 237560e..615502b 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -666,6 +666,7 @@ static int compact_node(int nid) > .nr_freepages = 0, > .nr_migratepages = 0, > .order = -1, > + .sync = true, > }; > > zone = &pgdat->node_zones[zoneid];
Yep I noticed that yesterday too.
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
| |