Messages in this thread | | | Subject | RE: [PATCH] scsi_dh_rdac: Fix error path | Date | Fri, 18 Nov 2011 09:34:01 -0500 | From | "Moger, Babu" <> |
| |
Looks good to me..
> -----Original Message----- > From: Richard Weinberger [mailto:richard@nod.at] > Sent: Thursday, November 17, 2011 6:44 PM > To: JBottomley@parallels.com > Cc: Moger, Babu; Somasundaram.Krishnasamy@lsi.com; yanling.qi@lsi.com; > linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Richard > Weinberger > Subject: [PATCH] scsi_dh_rdac: Fix error path > > If create_singlethread_workqueue() failes, rdac_init should fail too. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/scsi/device_handler/scsi_dh_rdac.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c > b/drivers/scsi/device_handler/scsi_dh_rdac.c > index 1d31279..2802394 100644 > --- a/drivers/scsi/device_handler/scsi_dh_rdac.c > +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c > @@ -934,6 +934,8 @@ static int __init rdac_init(void) > if (!kmpath_rdacd) { > scsi_unregister_device_handler(&rdac_dh); > printk(KERN_ERR "kmpath_rdacd creation failed.\n"); > + > + r = -EINVAL; > } > done: > return r; > -- > 1.7.7.3
| |