lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless
On Thu, 17 Nov 2011 23:43:40 +0100
Thomas Meyer <thomas@m3y3r.de> wrote:

> The semantic patch that makes this change is available
> in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
> num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
> pentry = (struct sfi_gpio_table_entry *)sb->pentry;
>
> - gpio_table = (struct sfi_gpio_table_entry *)
> + gpio_table =
> kmalloc(num * sizeof(*pentry), GFP_KERNEL);

True but the formatting also wants fixing with that change.



\
 
 \ /
  Last update: 2011-11-18 11:29    [W:0.033 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site