lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] pids: Make it possible to clone tasks with given pids
On 11/17/2011 10:36 PM, Oleg Nesterov wrote:
> My previous objection was wrong, I should try to find something else ;)
>
> On 11/17, Pavel Emelyanov wrote:
>>
>> +static int set_pidmap(struct pid_namespace *pid_ns, int pid)
>> +{
>> + int offset;
>> + struct pidmap *map;
>> +
>> + /*
>> + * When creating a new pid namespace we must make its init
>> + * have pid == 1 in it.
>> + */
>> + if (pid_ns->child_reaper == NULL)
>> + return 0;
>> +
>> + /*
>> + * Don't allow to create a task with a pid which has recently
>> + * belonged to some other (dead already) task. Only init (of
>> + * a freshly created namespace) and his clones can do this.
>> + */
>> + if (pid_ns->last_pid != 1)
>> + return -EPERM;
>> +
>> + map = &pid_ns->pidmap[pid/BITS_PER_PAGE];
>
> probably we should check that map < PIDMAP_ENTRIES ?

Yes, you're right here. The checks for given pid being correct are required. Will fix.

> Oleg.

Thanks,
Pavel


\
 
 \ /
  Last update: 2011-11-18 11:07    [W:0.203 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site