Messages in this thread | | | Subject | Re: [PATCH 2/7] event: don't divide events if it has field period | From | Peter Zijlstra <> | Date | Thu, 17 Nov 2011 09:45:08 +0100 |
| |
On Thu, 2011-11-17 at 11:22 +0300, Andrew Wagin wrote: > Hello Peter, > > 11 ноября 2011 г. 13:54 пользователь Andrew Vagin <avagin@gmail.com> написал: > > On 11/09/2011 03:55 PM, Peter Zijlstra wrote: > >> > >> On Mon, 2011-11-07 at 15:54 +0300, Andrew Vagin wrote: > >>> > >>> This patch solves the following problem: > >>> > >>> Now some samples may be lost due to throttling. The number of samples is > >>> restricted by sysctl_perf_event_sample_rate/HZ. A trace event is > >>> divided on some samples according to event's period. I don't sure, that > >>> we should generate more than one sample on each trace event. I think the > >>> better way to use SAMPLE_PERIOD. > >> > >> It would be yes, but this code predates that, also it needs to work even > >> if the user doesn't provide SAMPLE_PERIOD. > > I have not understood exactly what I should do now. > I'm going to send the third version of this patches. New version > contains only a small fix according with the comment for path 4/7. > In new version I am not going to fix the problem about which we > discussed early. I have some reasons for it:
I already merged your previous version, it can be found in tip.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |