lkml.org 
[lkml]   [2011]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix comparison using wrong pointer variable in dma debug code
    On Thu, Nov 17, 2011 at 08:31:02PM +0100, Thomas Jarosch wrote:
    > cppcheck reported:
    > [lib/dma-debug.c:248] -> [lib/dma-debug.c:248]: (style) Same expression on both sides of '=='.
    >
    > Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
    > ---
    > lib/dma-debug.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/lib/dma-debug.c b/lib/dma-debug.c
    > index 74c6c7f..fea790a 100644
    > --- a/lib/dma-debug.c
    > +++ b/lib/dma-debug.c
    > @@ -245,7 +245,7 @@ static void put_hash_bucket(struct hash_bucket *bucket,
    >
    > static bool exact_match(struct dma_debug_entry *a, struct dma_debug_entry *b)
    > {
    > - return ((a->dev_addr == a->dev_addr) &&
    > + return ((a->dev_addr == b->dev_addr) &&
    > (a->dev == b->dev)) ? true : false;
    > }
    >
    > --
    > 1.7.6.4
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >
    Thanks for the catch! Viro just pointed out you can also remove the ?
    true/false changes and extraneous parens, reducing it to:

    (a->dev_addr == b->dev_addr) && (a->dev == b->dev)
    But its not strictly necessecary

    Acked-by: Neil Horman <nhorman@tuxdriver.com>



    \
     
     \ /
      Last update: 2011-11-17 21:05    [W:0.031 / U:0.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site