Messages in this thread | | | Date | Thu, 17 Nov 2011 20:04:07 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 3/3] pids: Make it possible to clone tasks with given pids |
| |
On 11/17, Linus Torvalds wrote: > > Ok. Patches 1-2 look sane on their own. I think we can merge them > regardless in the next cycle if Oleg & co agree. Oleg?
I am not sure 1/3 really makes sense without 3/3... although it cleanups the "goto out" logic in alloc_pid().
Anyway I agree, the patches look fine.
> Patch 3 obviously is generating discussion and actually introduces new > functionality, so this one is the contentious one.. > > Linus > > On Thu, Nov 17, 2011 at 9:43 AM, Pavel Emelyanov <xemul@parallels.com> wrote: > > > > When restoring a task (or a set of tasks) we need to recreate them > > with exactly the same pid(s) as they had before. [...]
Yes.
Just in case, I believe technically 3/3 is correct too, modulo the small problem with the unchecked access to ->pidmap[] (unless I missed something again).
I am not sure about pid_max... probably we do not care in this case?
Oleg.
| |