lkml.org 
[lkml]   [2011]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix typo/thinko in get_random_bytes()
On 11/16/2011 11:41 AM, Thomas Gleixner wrote:
>
>
> On Wed, 16 Nov 2011, H. Peter Anvin wrote:
>
>> On 11/16/2011 10:50 AM, Luck, Tony wrote:
>>> If there is an architecture-specific random number generator we use
>>> it to acquire randomness one "long" at a time. We should put these
>>> random words into consecutive words in the result buffer - not just
>>> overwrite the first word again and again.
>>>
>>> Signed-off-by: Tony Luck <tony.luck@intel.com>
>>
>> Ouch. Good catch. This, I guess, is the downside of doing this only on
>> the kernel paths... made this kind of errors harder to catch.
>>
>> Acked-by: H. Peter Anvin <hpa@zytor.com>
>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>

Applied to x86/urgent... I'll try to get the tip-bot back online today
if I can find the time.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2011-11-17 17:37    [W:0.060 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site