lkml.org 
[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] gpio: add flags to export GPIOs when requesting
    Hi Stephen,

    On 11/16/2011 01:32 AM, Stephen Warren wrote:
    > Denis Kuzmenko wrote at Tuesday, November 15, 2011 4:05 PM:
    >> Hi Wolfram,
    >> On 11/16/2011 12:44 AM, Wolfram Sang wrote:
    >>
    >> #define GPIOF_EXPORT (1 << 2)
    >> #define GPIOF_EXPORT_DIR_CHANGEABLE (3 << 2)
    >
    > Then you won't have a single flag to check if the dir is changeable.
    >
    > Personally, I'd go for the two single-bit flags, and force boards to OR
    > them together if they want the GPIO exported and with a changeable
    > direction; just get rid of the two _DIR_ flags. That said, Wolfram's
    > patch seems to follow the conventions already in the file.

    Your truth.

    > Dong Aisheng posted patch "gpio: introduce gpio_export_array to ease
    > export for gpio arrays". Which should we pick; it doesn't seem like we
    > need both mechanisms.

    I vote for GPIOF_* variant (this one) since it can deal with different
    settings for each gpio pin in array.

    --
    Best regards, Denis Kuzmenko.


    \
     
     \ /
      Last update: 2011-11-16 09:21    [W:0.025 / U:60.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site