Messages in this thread | | | From | Rolf Eike Beer <> | Subject | Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1) | Date | Wed, 16 Nov 2011 23:51:01 +0100 |
| |
Andrei Warkentin wrote: > 1 is a power of two, therefore rounddown_pow_of_two(1) should return 1. It > does in case the argument is a variable but in case it's a constant it > behaves wrong and returns 0. Probably nobody ever did it so this was never > noticed, however net/drivers/vmxnet3 with latest GCC does and breaks on > unicpu systems.
Obviously correct.
Reviewed-by: Rolf Eike Beer <eike-kernel@sf-tec.de> [unhandled content-type:application/pgp-signature] | |