Messages in this thread | | | Date | Wed, 16 Nov 2011 20:41:15 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] fix typo/thinko in get_random_bytes() |
| |
On Wed, 16 Nov 2011, H. Peter Anvin wrote:
> On 11/16/2011 10:50 AM, Luck, Tony wrote: > > If there is an architecture-specific random number generator we use > > it to acquire randomness one "long" at a time. We should put these > > random words into consecutive words in the result buffer - not just > > overwrite the first word again and again. > > > > Signed-off-by: Tony Luck <tony.luck@intel.com> > > Ouch. Good catch. This, I guess, is the downside of doing this only on > the kernel paths... made this kind of errors harder to catch. > > Acked-by: H. Peter Anvin <hpa@zytor.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
| |