lkml.org 
[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] gpiolib: add irq_wake (power-management) sysfs file
On Wed, Nov 16, 2011 at 02:37:31PM +0000, Mark Brown wrote:
> On Wed, Nov 16, 2011 at 03:30:13PM +0100, Patrick Combes wrote:
>
> > > ...this doesn't do anything to stop userspace doing multiple enables and
> > > disables.
>
> > Do you mean there is a need to prevent that?
> > Basically the code above accepts both "1" or "enable" strings to enable the
> > property. I could limit that to "enable" / "disable" if it is confusing.
>
> That's not the problem. The problem is that if you disable it might not
> actually disable the wake if it's previously been enabled multiple times.

You're right; I however wonder if this API should work as 'enable_irq_wake' or
if it should filter multiple enables/disables. I'd have supposed it's a choice
of implementation but based on your comment I understand filtering is the
expected way. I'll modify the function accordingly. Thanks


\
 
 \ /
  Last update: 2011-11-16 18:27    [W:0.125 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site