lkml.org 
[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/5] dmaengine: add ep93xx DMA support
On Tue, Nov 15, 2011 at 11:59:50AM -0600, H Hartley Sweeten wrote:
> >
> > Index: linux-2.6/drivers/dma/ep93xx_dma.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/dma/ep93xx_dma.c
> > +++ linux-2.6/drivers/dma/ep93xx_dma.c
> > @@ -246,6 +246,7 @@ static void ep93xx_dma_set_active(struct
> > static struct ep93xx_dma_desc *
> > ep93xx_dma_get_active(struct ep93xx_dma_chan *edmac)
> > {
> > + BUG_ON(list_empty(&edmac->active));
>
> BUG_ON is evil...
>
> I'm not sure this is the right way to handle this.
>
> If your doing dma the list should never be empty. If it is I think it should
> have been caught way before this. Mika, do you have any comments?

I agree - the list should never be empty when this is called. The actual bug
is somewhere else.


\
 
 \ /
  Last update: 2011-11-16 07:51    [W:0.088 / U:19.648 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site