Messages in this thread | | | Subject | Re: [PATCH 3/4] mmc: Logging neatening | From | Joe Perches <> | Date | Tue, 15 Nov 2011 18:00:46 -0800 |
| |
On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote: > 2011/11/16 Joe Perches <joe@perches.com>: > > On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote: > > > > [123K of untrimmed reply] > > > > If you wrote something, I didn't find it. > > > > > - dev_info(&pdev->dev, "DW MMC controller at irq %d, " > > - "%d bit host data width, " > > - "%u deep fifo\n", > > + dev_info(&pdev->dev, > > + "DW MMC controller at irq %d, %d bit host data width, %u deep fifo\n", > > irq, width, fifo_size); > > I think that tab is needed this "DW MMC controller at irq ...." ?
Argument alignment isn't always the right thing.
Very long formats should not necessarily be aligned at the open parenthesis. It helps to determine when the format string or the dmesg output line length is too long.
| |