lkml.org 
[lkml]   [2011]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] mmc: Logging neatening
From
Date
On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote:
> 2011/11/16 Joe Perches <joe@perches.com>:
> > On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
> >
> > [123K of untrimmed reply]
> >
> > If you wrote something, I didn't find it.
> >
>
> > - dev_info(&pdev->dev, "DW MMC controller at irq %d, "
> > - "%d bit host data width, "
> > - "%u deep fifo\n",
> > + dev_info(&pdev->dev,
> > + "DW MMC controller at irq %d, %d bit host data width, %u deep fifo\n",
> > irq, width, fifo_size);
>
> I think that tab is needed this "DW MMC controller at irq ...." ?

Argument alignment isn't always the right thing.

Very long formats should not necessarily be aligned
at the open parenthesis. It helps to determine
when the format string or the dmesg output line length
is too long.







\
 
 \ /
  Last update: 2011-11-16 03:03    [W:0.057 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site