Messages in this thread | | | Date | Wed, 16 Nov 2011 09:15:12 +0800 | Subject | Re: [PATCCH percpu: add cpunum param in per_cpu_ptr_to_phys | From | Dave Young <> |
| |
On Tue, Nov 15, 2011 at 10:49 PM, Tejun Heo <tj@kernel.org> wrote: > On Tue, Nov 15, 2011 at 04:36:46PM +0800, Dave Young wrote: >> per_cpu_ptr_to_phys iterate all cpu to get the phy addr >> let's leave the caller to pass the cpu number to it. >> >> Actually in the only one user show_crash_notes, >> cpunum is provided already before calling this. >> >> Signed-off-by: Dave Young <dyoung@redhat.com> > > Does this matter? If it's not a performance critical path, I'd rather > keep the generic funtionality.
Hi, why not? the code is redundant, it's an improvement of the code, isn't it? Also, kernel code size will be smaller.
> > Thanks. > > -- > tejun > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
-- Regards Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |