lkml.org 
[lkml]   [2011]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] gpiolib: add irq_wake (power-management) sysfs file
On Tue, Nov 15, 2011 at 01:16:37PM +0000, Mark Brown wrote:
> On Fri, Nov 11, 2011 at 10:40:06AM +0100, Patrick Combes wrote:
> > + else if (sysfs_streq(buf, "enable") || sysfs_streq(buf, "1"))
> > + status = enable_irq_wake(gpio_to_irq(gpio));
> > + else if (sysfs_streq(buf, "disable") || sysfs_streq(buf, "0"))
> > + status = disable_irq_wake(gpio_to_irq(gpio));
> > + else
> > + status = -EINVAL;
>
> ...this doesn't do anything to stop userspace doing multiple enables and
> disables.

It doesn't check whether gpio_to_irq(gpio) returns something sane either.
It should be doing something like this before taking the mutex:

irq = gpio_to_irq(gpio);
if (irq <= 0)
return irq < 0 ? irq : -EINVAL;

and then doing (enable|disable)_irq_wake() on irq.


\
 
 \ /
  Last update: 2011-11-15 18:23    [W:0.061 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site