lkml.org 
[lkml]   [2011]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH FIX net v2] forcedeth: fix stats on hardware without extended stats support
From
From: David Decotigny <david.decotigny@google.com>
Date: Fri, 11 Nov 2011 18:27:34 -0800

> This change makes sure that tx_packets/rx_bytes ifconfig counters are
> updated even on NICs that don't provide hardware support for these
> stats: they are now updated in software. For the sake of consistency,
> we also now have tx_bytes updated in software (hardware counters
> include ethernet CRC, and software doesn't account for it).
>
> This reverts parts of:
> - "forcedeth: statistics optimization" (21828163b2)
> - "forcedeth: Improve stats counters" (0bdfea8ba8)
> - "forcedeth: remove unneeded stats updates" (4687f3f364)
>
> Tested:
> pktgen + loopback (http://patchwork.ozlabs.org/patch/124698/)
> reports identical tx_packets/rx_packets and tx_bytes/rx_bytes.
>
> Signed-off-by: David Decotigny <david.decotigny@google.com>

Applied, thanks.


\
 
 \ /
  Last update: 2011-11-14 06:17    [W:0.060 / U:2.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site