lkml.org 
[lkml]   [2011]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the pm tree (and warning)
Hello, Guennadi.

On Tue, Nov 15, 2011 at 12:33:29AM +0100, Guennadi Liakhovetski wrote:
> No, this isn't a correct fix.

I've been looking at the code and am scratching my head about what
happens after timeout. If test timed out (tmo == 0), it prints out
error message and continues to the next iteration of the test loop,
which will reinitialize the on-stack completion. This essentially
makes the previous test run's callback_param pointer dangling. The
completion needs to be either detached from the callback or waited
upon even if it timed out. Am I missing something?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-11-15 00:43    [from the cache]
©2003-2011 Jasper Spaans