[lkml]   [2011]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 5/5] regmap: Do not call regcache_exit from regcache_lzo_init error path
On Mon, Nov 14, 2011 at 10:40:19AM +0100, Lars-Peter Clausen wrote:
> Calling regcache_exit from regcache_lzo_init is a layering violation and
> might cause double frees. In case of an error only free those structures which
> have been allocated in this function.

You should also be explaining here why the cleanup done the core exit
function is still being done when the code is changed this way. The
fact that it may be a layering violation doesn't mean that the cleanup
is actually being done anywhere else...

 \ /
  Last update: 2011-11-14 22:45    [W:0.098 / U:10.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site