lkml.org 
[lkml]   [2011]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 3.2-rc1 28/28] uprobes: introduce UTASK_SSTEP_TRAPPED logic
On 11/11, Srikar Dronamraju wrote:
>
> +void __weak abort_xol(struct pt_regs *regs, struct uprobe_task *utask)
> +{
> + set_instruction_pointer(regs, utask->vaddr);
> +}

OK, this is fine on 32bit. But X86_64 should also handle
UPROBES_FIX_RIP_AX/CX?

IOW, shouldn't we also do

if (uprobe->fixups & UPROBES_FIX_RIP_AX)
regs->ax = tskinfo->saved_scratch_register;
else if (uprobe->fixups & UPROBES_FIX_RIP_CX)
regs->cx = tskinfo->saved_scratch_register;

on 64bit?

Oleg.



\
 
 \ /
  Last update: 2011-11-14 17:47    [W:0.119 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site