lkml.org 
[lkml]   [2011]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 9/9] bq27x00: Fix OOPS caused by unregistring bq27x00 driver
    Date
    On Tuesday 01 November 2011 01:43:11 you wrote:
    > * power_supply_unregister call bq27x00_battery_get_property which call
    > bq27x00_battery_poll * make sure that bq27x00_battery_poll will not call
    > schedule_delayed_work again after unregister (which cause OOPS)
    >
    > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
    > ---
    > drivers/power/bq27x00_battery.c | 4 ++++
    > 1 files changed, 4 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/power/bq27x00_battery.c
    > b/drivers/power/bq27x00_battery.c index 15ecd42..29ce907 100644
    > --- a/drivers/power/bq27x00_battery.c
    > +++ b/drivers/power/bq27x00_battery.c
    > @@ -722,6 +722,10 @@ static int bq27x00_powersupply_init(struct
    > bq27x00_device_info *di)
    >
    > static void bq27x00_powersupply_unregister(struct bq27x00_device_info *di)
    > {
    > + /* power_supply_unregister call bq27x00_battery_get_property which call
    > bq27x00_battery_poll */ + /* make sure that bq27x00_battery_poll will not
    > call schedule_delayed_work again after unregister (which cause OOPS) */
    > + poll_interval = 0;
    > +
    > cancel_delayed_work_sync(&di->work);
    >
    > bq27x00_battery_reg_exit(di);

    Can somebody review this patch series? At least this last patch fix rebooting
    device Nokia N900 after unloading bq27x00_battery module with rmmod!

    --
    Pali Rohár
    pali.rohar@gmail.com[unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-11-13 22:01    [W:0.023 / U:2.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site