lkml.org 
[lkml]   [2011]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging
On Sun, 6 Nov 2011, Dmitry Torokhov wrote:

> > I am not a hid expert; but all hid low level drivers appear to do this.
> > Initially, I was directly invoking hid_connect() directly and based on your
> > Input, I chose to use hid_hw_start() which all other drivers are using.
>
> Note that the users of hid_hw_start() actually are not low level
> drivers, such as usbhid or bluetooth hidp, but higher-level drivers,
> such as hid-wacom, hid-a4tech, etc. Since your driver is a low-level
> driver (a provider so to speak) it should not call hid_hw_start() on its
> own but rather wait for the hid code to do it.
>
> Still, I am not a HID expert either so I'll defer to Jiri here.

Hi,

my understanding is that hv driver is actually a bit special in this
respect -- it's actually all-in-one both low-level and high-level driver.
I take it that there is not ever going to be a different high-level driver
using low-level hv transport (is that correct, KY?), so this might indeed
be an acceptable layout of the driver.

Thanks a lot,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2011-11-13 21:03    [W:0.114 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site