Messages in this thread |  | | Date | Sun, 13 Nov 2011 10:48:00 +0100 | | From | Wolfram Sang <> | | Subject | Re: [PATCH] powerpc/p3060qds: Fix select of 'MPC8xxx_GPIO' |
| |
On Sun, Nov 13, 2011 at 12:50:30AM +0100, Paul Bolle wrote: > The driver for the Freescale P3060 QDS got added by commit 96cc017c5b > ("[...] Add support for P3060QDS board"). Its Kconfig entry selects > MPC8xxx_GPIO. But at the time that driver got added MPC8xxx_GPIO was > already renamed to GPIO_MPC8XXX, by commit c68308dd50c ("gpio: move > mpc8xxx/512x gpio driver to drivers/gpio"). > > So make this driver select GPIO_MPC8XXX. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Thanks for catching this!
> 2) The config tools do not complain about selects that cannot be met > because they concern a Kconfig symbol that doesn't even exist. Shouldn't > they be made to complain in that case?
I'd think so.
Regards,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] |  |