Messages in this thread |  | | From | Robert Jarzmik <> | | Subject | Re: [PATCH v2 04/16] mtd/docg3: fix BCH registers | | Date | Sun, 13 Nov 2011 11:20:14 +0100 |
| |
Mike Dunn <mikedunn@newsguy.com> writes:
> On 11/10/2011 12:05 AM, Robert Jarzmik wrote: >> -#define DOC_BCH_SYNDROM(idx) (0x1048 + (idx << 1)) >> +#define DOC_BCH_SYNDROM(idx) (0x1048 + (idx << 0)) > > > Minor nit: why the 0, and not just (0x1048 + idx) ? I'll fix that, old idea I had that address bus did not stand odd adresses, and I couldn't convince myself the "<< 0" was right, so left it to have back quicky "<< 1". But I was wrong :)
Cheers.
-- Robert
|  |