lkml.org 
[lkml]   [2011]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 5/5] mm: Only IPI CPUs to drain local pages if they exist
Date
Calculate a cpumask of CPUs with per-cpu pages in any zone
and only send an IPI requesting CPUs to drain these pages
to the buddy allocator if they actually have pages when
asked to flush.

The code path of memory allocation failure for CPUMASK_OFFSTACK=y
config was tested using fault injection framework.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Russell King <linux@arm.linux.org.uk>
CC: linux-mm@kvack.org
CC: Christoph Lameter <cl@linux-foundation.org>
CC: Pekka Enberg <penberg@kernel.org>
CC: Matt Mackall <mpm@selenic.com>
CC: Sasha Levin <levinsasha928@gmail.com>
CC: Rik van Riel <riel@redhat.com>
CC: Andi Kleen <andi@firstfloor.org>
---
mm/page_alloc.c | 18 +++++++++++++++++-
1 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9dd443d..44dc6c5 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1119,7 +1119,23 @@ void drain_local_pages(void *arg)
*/
void drain_all_pages(void)
{
- on_each_cpu(drain_local_pages, NULL, 1);
+ int cpu;
+ struct zone *zone;
+ cpumask_var_t cpus;
+ struct per_cpu_pageset *pageset;
+
+ if (likely(zalloc_cpumask_var(&cpus, GFP_ATOMIC))) {
+ for_each_populated_zone(zone) {
+ for_each_online_cpu(cpu) {
+ pageset = per_cpu_ptr(zone->pageset, cpu);
+ if (pageset->pcp.count)
+ cpumask_set_cpu(cpu, cpus);
+ }
+ }
+ on_each_cpu_mask(cpus, drain_local_pages, NULL, 1);
+ free_cpumask_var(cpus);
+ } else
+ on_each_cpu(drain_local_pages, NULL, 1);
}

#ifdef CONFIG_HIBERNATION
--
1.7.0.4


\
 
 \ /
  Last update: 2011-11-13 11:21    [from the cache]
©2003-2011 Jasper Spaans