[lkml]   [2011]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] [TRIVIAL] spi: drop "select SPI_MASTER_OF"
    There is no Kconfig symbol named SPI_MASTER_OF. The select statement for
    that symbol is a nop. Drop it.

    While we're touching that Kconfig entry also drop a superfluous
    dependency on SPI (this entry is wrapped in "if SPI" / "endif").

    Signed-off-by: Paul Bolle <>
    0) Tested with "yes "" | make ARCH=powerpc config" before and after
    applying this patch. Identical .config files were generated, as was

    1) This select statement was added in commit 42bbb70980 ("powerpc/5200:
    Add mpc5200-spi (non-PSC) device driver"). Perhaps this was a leftover
    from some draft development. (Currently it seems OF_SPI, a hidden
    config, will do the right thing for the interaction of OF and SPI master
    controllers. Not that I understand this stuff ...)

    drivers/spi/Kconfig | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
    index a1fd73d..950ccb7 100644
    --- a/drivers/spi/Kconfig
    +++ b/drivers/spi/Kconfig
    @@ -174,8 +174,7 @@ config SPI_LM70_LLP

    config SPI_MPC52xx
    tristate "Freescale MPC52xx SPI (non-PSC) controller support"
    - depends on PPC_MPC52xx && SPI
    - select SPI_MASTER_OF
    + depends on PPC_MPC52xx
    This drivers supports the MPC52xx SPI controller in master SPI

     \ /
      Last update: 2011-11-13 22:55    [W:0.020 / U:2.212 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site