Messages in this thread Patch in this message | | | Subject | [PATCH] ecryptfs: Use kmemdup rather than duplicating its implementation | From | Thomas Meyer <> | Date | Sat, 12 Nov 2011 10:27:52 +0100 |
| |
Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c --- a/fs/ecryptfs/messaging.c 2011-11-07 19:38:22.340474214 +0100 +++ b/fs/ecryptfs/messaging.c 2011-11-08 10:34:54.896614796 +0100 @@ -350,14 +350,13 @@ int ecryptfs_process_response(struct ecr goto unlock; } msg_size = (sizeof(*msg) + msg->data_len); - msg_ctx->msg = kmalloc(msg_size, GFP_KERNEL); + msg_ctx->msg = kmemdup(msg, msg_size, GFP_KERNEL); if (!msg_ctx->msg) { rc = -ENOMEM; printk(KERN_ERR "%s: Failed to allocate [%zd] bytes of " "GFP_KERNEL memory\n", __func__, msg_size); goto unlock; } - memcpy(msg_ctx->msg, msg, msg_size); msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_DONE; rc = 0; wake_up:
| |