Messages in this thread | | | Date | Fri, 11 Nov 2011 17:07:11 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 0/2] mfd/stmpe: Add SPI interface support |
| |
On 11/11/2011 5:02 PM, Rabin Vincent wrote: > On Fri, Nov 11, 2011 at 15:59, Viresh Kumar <viresh.kumar@st.com> wrote: >> On 11/11/2011 3:13 PM, Rabin Vincent wrote: >>> Could you instead convert stmpe to use the register map API, and then >>> add the SPI interface? Converting to regmap should both simplify the >>> existing code as well as make it possible to add the second interface >>> with fewer lines of code. >> >> Sorry Rabin, but i couldn't get your comment completely. :( >> Can you please spend few lines on "what do you mean by register map API"? > > drivers/base/regmap, added in b83a313bf25 ("regmap: Add generic > non-memory mapped register access API"). > > Several MFDs are already using it (git grep regmap drivers/mfd/), and > patches to convert more are making the rounds on the lists.
Ok. Got it now. :)
Can we get this patchset pushed as it is and i will do this regmap stuff later in a separate patchset? Actually i am a bit busy currently with some other activities and can come back to it after some time.
-- viresh
| |