lkml.org 
[lkml]   [2011]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 08/16] ARM: LPAE: Page table maintenance for the 3-level format
On Thu, Nov 10, 2011 at 09:59:33PM +0000, Nicolas Pitre wrote:
> On Mon, 7 Nov 2011, Catalin Marinas wrote:
>
> > This patch modifies the pgd/pmd/pte manipulation functions to support
> > the 3-level page table format. Since there is no need for an 'ext'
> > argument to cpu_set_pte_ext(), this patch conditionally defines a
> > different prototype for this function when CONFIG_ARM_LPAE.
>
> Maybe it doesn't make sense to still call it cpu_set_pte_ext then?

We could do this but it adds several #ifdef's, especially if we also
change macro names like set_pte_ext(). Otherwise we could leave the
latter macro unchanged and only change the name in the processor
structure. But I think it just adds more clutter.

--
Catalin


\
 
 \ /
  Last update: 2011-11-11 11:57    [W:0.054 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site