lkml.org 
[lkml]   [2011]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [PATCH net-next v1] net-forcedeth: Add internal loopback support for forcedeth NICs.
    From
    From: Sanjay Hortikar <horti@google.com>
    Date: Wed, 9 Nov 2011 12:45:25 -0800

    > @@ -5124,6 +5266,12 @@ static int nv_open(struct net_device *dev)
    >
    > spin_unlock_irq(&np->lock);
    >
    > + /* If the loopback feature was set while the device was down, make sure
    > + * that it's set correctly now.
    > + */

    Improperly formatted comment, it should be:

    /*
    *
    */

    > @@ -5328,6 +5476,10 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
    >
    > dev->features |= dev->hw_features;
    >
    > + /* Add loopback capability to the device. */
    > + dev->hw_features |= NETIF_F_LOOPBACK;
    > +
    > +
    > np->pause_flags = NV_PAUSEFRAME_RX_CAPABLE | NV_PAUSEFRAME_RX_REQ | NV_PAUSEFRAME_AUTONEG;

    Please do not add all of these extra empty lines.


    \
     
     \ /
      Last update: 2011-11-12 02:31    [W:0.022 / U:0.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site