Messages in this thread Patch in this message | | | Subject | [PATCH] drivers/memstick: Use kmemdup rather than duplicating its implementation | From | Thomas Meyer <> | Date | Thu, 10 Nov 2011 19:42:33 +0100 |
| |
From: Thomas Meyer <thomas@m3y3r.de>
Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c --- a/drivers/memstick/core/mspro_block.c 2011-11-07 19:39:05.517796746 +0100 +++ b/drivers/memstick/core/mspro_block.c 2011-11-08 10:52:46.510979781 +0100 @@ -1034,12 +1034,11 @@ static int mspro_block_read_attributes(s } msb->attr_group.name = "media_attributes"; - buffer = kmalloc(attr_len, GFP_KERNEL); + buffer = kmemdup((char *)attr, attr_len, GFP_KERNEL); if (!buffer) { rc = -ENOMEM; goto out_free_attr; } - memcpy(buffer, (char *)attr, attr_len); for (cnt = 0; cnt < attr_count; ++cnt) { s_attr = kzalloc(sizeof(struct mspro_sys_attr), GFP_KERNEL);
| |