lkml.org 
[lkml]   [2011]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/10] cgroup: subsys->attach_task() should be called after migration
    Date
    cgroup_attach_task() calls subsys->attach_task() after
    cgroup_task_migrate(); however, cgroup_attach_proc() calls it before
    migration. This actually affects some of the users. Update
    cgroup_attach_proc() such that ->attach_task() is called after
    migration.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@Jp.fujitsu.com>
    Cc: Paul Menage <paul@paulmenage.org>
    Cc: Li Zefan <lizf@cn.fujitsu.com>
    ---
    kernel/cgroup.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/kernel/cgroup.c b/kernel/cgroup.c
    index 83e10f9..3679fb6 100644
    --- a/kernel/cgroup.c
    +++ b/kernel/cgroup.c
    @@ -2152,13 +2152,15 @@ int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader)
    oldcgrp = task_cgroup_from_root(tsk, root);
    if (cgrp == oldcgrp)
    continue;
    +
    + retval = cgroup_task_migrate(cgrp, oldcgrp, tsk, true);
    + BUG_ON(retval != 0);
    +
    /* attach each task to each subsystem */
    for_each_subsys(root, ss) {
    if (ss->attach_task)
    ss->attach_task(cgrp, tsk);
    }
    - retval = cgroup_task_migrate(cgrp, oldcgrp, tsk, true);
    - BUG_ON(retval != 0);
    }
    /* nothing is sensitive to fork() after this point. */

    --
    1.7.3.1


    \
     
     \ /
      Last update: 2011-11-02 00:49    [W:0.021 / U:87.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site