[lkml]   [2011]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 33/36] Hexagon: Add configuration and makefiles for the Hexagon architecture.
On Tue, 2011-11-01 at 12:27 -0500, Richard Kuo wrote:
> On Tue, Nov 01, 2011 at 10:30:46AM +0100, Paul Bolle wrote:
> > Is GENERIC_PENDING_IRQ also a pending project?
> Yes.

So, you'll move it up a line?

> > > +#config ZONE_DMA
> > > +# bool
> > > +# default y
> >
> > Why is this added commented out?
> We were using it before, but not anymore.

So, please drop it.

> > > + def_bool y
> > > + select STACKTRACE
> >
> > Some grepping suggests that the tracing infrastructure will "select
> > STACKTRACE" if the architecture sets STACKTRACE_SUPPORT (tile apparently
> > also gets this wrong). Have I grepped this correctly?
> Only if DEBUG_KMEMLEAK is selected apparently (?)

But "config TRACING" (in kernel/trace/Kconfig) also selects it if
STACKTRACE_SUPPORT is set. It seems GENERIC_TRACER is the hidden magic
here. GENERIC_TRACER is selected by the various tracer options - see
kernel/trace/Kconfig again, I'm unfamiliar with this stuff - and will
itself select TRACING. So if an arch has STACKTRACE_SUPPORT set it
doesn't have to select STACKTRACE itself. (Note that - except for tile -
no other arch selects STACKTRACE.)

But hopefully someone who doesn't have to grep the Kconfig files to
understand this, can tell us for sure.

> We felt it was better to remove the platform code for this submission
> as it was not exactly clean and did not use the devtree code. That's
> why it's commented out of the Makefiles.

If you really feel you need to add it, but commented out, perhaps a
comment can be added to keep people like me from submitting patches to
remove it.

Paul Bolle

 \ /
  Last update: 2011-11-01 20:03    [W:0.038 / U:3.984 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site