lkml.org 
[lkml]   [2011]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] freezer: revert 27920651fe "PM / Freezer: Make fake_signal_wake_up() wake TASK_KILLABLE tasks too"
On 11/01, Tejun Heo wrote:
>
> Yeah yeah, Trond already pointed it out. I forgot about the
> sigpending special case in schedule(), which I think is rather odd,

I disagree with "rather odd" ;)

We have a lot of examples of

current->state = TASK_INTERRUPTIBLE;
...
if (signal_pending())
break;
schedule();

Without that special case in schedule() the code above becomes racy.
Just consider __wait_event_interruptible().

> Any better ideas?

Well. As a simple (probably temporary) fix, I'd suggest

#define wait_event_freezekillable(wq, condition)
{
freezer_do_not_count();
__retval = wait_event_killable(condition);
freezer_count();
__retval;
}

Do you think it can work?

Oleg.



\
 
 \ /
  Last update: 2011-11-01 19:21    [W:0.061 / U:4.396 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site