lkml.org 
[lkml]   [2011]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][mm:] adjust the logic of checking THP
From
Date
Perhaps a summary would help the people actually knowledgeable about mm
understand why this adjustment is needed.

I'll just mention a few obvious things.

On Tue, 2011-11-01 at 19:41 +0800, Guanjun He wrote:
> Signed-off-by: Guanjun He <heguanbo@gmail.com>
> ---
> mm/memory.c | 32 ++++++++++++++++++--------------
> 1 files changed, 18 insertions(+), 14 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index a56e3ba..d6dd6b3 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3465,20 +3465,24 @@ int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct *vma,
> pmd = pmd_alloc(mm, pud, address);
> if (!pmd)
> return VM_FAULT_OOM;
> - if (pmd_none(*pmd) && transparent_hugepage_enabled(vma)) {
> - if (!vma->vm_ops)
> - return do_huge_pmd_anonymous_page(mm, vma, address,
> - pmd, flags);
> - } else {
> - pmd_t orig_pmd = *pmd;
> - barrier();
> - if (pmd_trans_huge(orig_pmd)) {
> - if (flags & FAULT_FLAG_WRITE &&
> - !pmd_write(orig_pmd) &&
> - !pmd_trans_splitting(orig_pmd))
> - return do_huge_pmd_wp_page(mm, vma, address,
> - pmd, orig_pmd);
> - return 0;
> + if (transparent_hugepage_enabled(vma)) {
> + if(pmd_none(*pmd)){

codingstyle (scripts/checkpatch.pl would have caught that one).

> + if (!vma->vm_ops)
> + return do_huge_pmd_anonymous_page(mm, vma, address,
> + pmd, flags);
> + }
> + else
> + {

codingstyle (ditto). There's probably more.

> + pmd_t orig_pmd = *pmd;
> + barrier();
> + if (pmd_trans_huge(orig_pmd)) {
> + if (flags & FAULT_FLAG_WRITE &&
> + !pmd_write(orig_pmd) &&
> + !pmd_trans_splitting(orig_pmd))
> + return do_huge_pmd_wp_page(mm, vma, address,
> + pmd, orig_pmd);
> + return 0;
> + }
> }
> }
>


Paul Bolle



\
 
 \ /
  Last update: 2011-11-01 13:29    [W:0.045 / U:4.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site